| commit | 1b1cb0c2f90fb1ac65bfe77294d24e60229eb856 | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Thu Apr 10 07:54:15 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 10 07:54:15 2025 |
| tree | 54ddf09c1f3d49501ee6d740970c2ce01d056fce | |
| parent | 711b25538d4cedd9bd065bdb6f3509fac6235087 [diff] |
Avoid lambda with auto parameter in ForEachRule The remaining Windows-only crashes in Issue 389011795 show some really bizarre behavior: somehow, we're passing index=0x1A1FD1A0 into HasNestedDeclarationsAtIndex, where 0x1A1FD1A0 appears to be a (truncated) pointer to the stack. I have no explanation for this, and absent any repro of the issue, the only remaining move is to make this code gradually less "creative"/complex until the issue hopefully disappears. This is a shot in the dark. Bug: 389011795 Change-Id: I2ff0e692fc3b3811c893f4226989f3331f7ce831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6439356 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#1445140}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.