Google Git
Sign in
chromium / chromium / src / 1b2c58c9c465694cac0718f872a59e9b90044169
commit1b2c58c9c465694cac0718f872a59e9b90044169[log] [tgz]
authorGeorg Neis <neis@chromium.org>Sun Dec 04 02:03:10 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sun Dec 04 02:03:10 2022
treefdc1a8a7e4e1e39063b55eb23dc327912a040fc9
parent48afc6217a6ebe92cad9a3913cbc9ae52a9d6ab4 [diff]
system_web_apps: Generalize ShouldReuseExistingWindow

Replace SystemWebAppDelegate's ShouldReuseExistingWindow with a function
GetWindowForLaunch that returns the window to be reused or, to request
a new window, nullptr. The default implementation uses
FindSystemWebAppBrowser such that an existing window is reused as
before.

Besides giving system web apps more flexibility, this lets us simplify
crosapi's UrlAshHandler and makes it easier to invoke the OS_URL_HANDLER
app from elsewhere (esp. in an upcoming CL).

Bug: chromium:1338903
Change-Id: I42c1a52116e93304c4b485581229e790eaf9a19e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4060866
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078980}
25 files changed
tree: fdc1a8a7e4e1e39063b55eb23dc327912a040fc9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.