Google Git
Sign in
chromium / chromium / src / 1bc384a568b7dcc147cdf9caf8a91956ac074b63
commit1bc384a568b7dcc147cdf9caf8a91956ac074b63[log] [tgz]
authorPatrick Monette <pmonette@chromium.org>Fri Oct 02 16:41:33 2020
committerCommit Bot <commit-bot@chromium.org>Fri Oct 02 16:41:33 2020
tree503a6b3cb439af804fccb51369cae501b6d172cb
parentdab3e4055ec793ff785372a042c767373067d48b [diff]
[PM] Change DCHECKs into DumpWithoutCrashing in SWContextAdapter

The DCHECKs were added to generate crashes to help me solve a lifetime
issue with service worker controllees, but I underestimated how often
the issue happens and have had no crashes yet.

Changing them to DumpWithoutCrashing will make it so that anyone on
canary will be able to hit them.

This CL is meant to be reverted as soon as enough crashes are received
to debug the root issue.

Bug: 1086944, 1088353
Change-Id: I50904f30ba8d23a5e5661edf8f1cf4d341e6dfef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444370
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813227}
1 file changed
tree: 503a6b3cb439af804fccb51369cae501b6d172cb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.