commit | 1c1992d02fa89792498f5e3533772bd65d93973d | [log] [tgz] |
---|---|---|
author | Christopher Cameron <ccameron@chromium.org> | Fri Dec 07 07:00:51 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 07:00:51 2018 |
tree | 61b74236f53f9d3e57dc639ba6b517efeaf21b13 | |
parent | 1ca54644ff73878027d7903ab3bd6288561e68a8 [diff] |
RemoteMacViews: Wire up menu items and shortcut keys For menu items and shortcut keys to work, PWA windows need to have the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler structures set on them. This cannot be done by a method on views_bridge_mac::mojom:: BridgedNativeWidget, because the structures to be created exist in Chrome, which would be a layering violation. Introduce a method to chrome::mojom::AppShim which takes a widget id, creates the ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler, and assigns them to the corresponding BridgedNativeWidgetImpl. Bug: 895169 Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a Reviewed-on: https://chromium-review.googlesource.com/c/1364210 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#614631}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .