Implement OnHidden and OnShown for UnstartedPagePaintObserver When a navigation is started and before the first contentful paint the page is hidden (because there was a tab switch or the browser window was minimized), the navigation_timeout_timer_ keeps running potentially expiring and reporting the histogram with Timeout set to true. However, in some cases it may be that navigation is completed when the tab is back to shown. In this case we should stop the time when the tab is hidden (OnHidden) and start it in the case it is shown (OnShown) and the first contentful paint was not yet received. OBSOLETE_HISTOGRAM[PageLoad.Clients.NavigationToFirstContentfulPaint.Timeout]=Replaced by PageLoad.Clients.NavigationToFirstContentfulPaint.Timeout2 Change-Id: Ia6e1eb638e9bbcaea8a404cd94fbebc23214196a Bug: 380411637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042605 Commit-Queue: Sergio Gonzalez Martin <sergiog@microsoft.com> Reviewed-by: Andrew Williams <awillia@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1389298}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.