Google Git
Sign in
chromium / chromium / src / 1c61e650b0e4f6f65f1fb89f7d05df4a35e86426
commit1c61e650b0e4f6f65f1fb89f7d05df4a35e86426[log] [tgz]
authorKent Tamura <tkent@chromium.org>Tue Dec 15 04:37:41 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Dec 15 04:37:41 2020
treed4a6557077116c6c5c7898759d2ad5ceef1bdea6
parent04d941be026b69a94a7a7731ed9fdd525b552c7a [diff]
css-lists: counter-* properties update should invalidate ListItemOrdinals

Since r835809, list-items respect to counter-* properties, but we didn't
invalidate list-items on updating the properties.

LayoutCounter::LayoutObjectStyleChanged(), which is called whenever
counter-* properties are changed, invalidates ListItemOrdinal too.

* LayoutCounter::LayoutObjectStyleChanged() calls new function
  ListItemOrdinal::ItemCounterStyleUpdated()

* ListItemOrdinal::ItemInsertedOrRemoved() is renamed to ItemUpdated(),
  and it adds support of inclusive invalidation.

* ListItemOrdinal::ItemInsertedOrRemoved() and
  ItemCounterStyleUpdated() call ItemUpdated().

* counter-set-002.html
 - Fix the flakiness
 - Add list-items before/after the updated node

Bug: 1157854
Change-Id: I669c2c70f87473d5d863f5f02208eb7fe1a41a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586455
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836962}
6 files changed
tree: d4a6557077116c6c5c7898759d2ad5ceef1bdea6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.