commit | 1c6c8d3619c124fdba19652582b091b6f0730a37 | [log] [tgz] |
---|---|---|
author | Jordan Demeulenaere <jdemeulenaere@google.com> | Tue Mar 12 17:32:26 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 12 17:32:26 2019 |
tree | e2b1aaae443705e06fc9c0ecce788ba903c7a3b4 | |
parent | 373064ed77308b87647804e02c6a02aede3a0c36 [diff] |
[Autofill Assistant] Prevent crash when animating carousel. This CL prevents the application from crashing when hiding then showing and update a carousel in the same short period. This bug is due to incompatibilities between animations performed by the LayoutTransition in the bottom bar container (enabled via the animateLayoutChanges attribute) and the animations inside the RecyclerView performed by the default ItemAnimation. The possible workaround are: 1) Disable animateLayoutChanges on the bottom bar container. This would disable all animations currently triggered when any of its children is shown or hidden. 2) Disable carousels animations. This would disable the current transition animation when chips change (e.g. centered 'Cancel' chip to a 'Cancel' and 'Done' chip aligned to the right). 3) Never hide the carousels, so that they are not impacted by the layout transition from the bottom bar container. This would disabled animations when a carousel is shown or hidden. This CL implements solution 3), as most of the time the suggestions carousel is empty and actions carousel is not. Change-Id: Icacf01afcd13a2af423e57963c733198d9cc9e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518512 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#639995}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .