Google Git
Sign in
chromium / chromium / src / 1c72f5185c38f1ae91cb0c6f63f6c1e1e204ed6d
commit1c72f5185c38f1ae91cb0c6f63f6c1e1e204ed6d[log] [tgz]
authorSarah Krakowiak Criel <skrakowi@chromium.org>Tue Aug 27 14:48:45 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 27 14:48:45 2024
tree4ab43ae89ad108f609b0c13601ae1b363ff3acba
parent4396c0ba321442ec6493a61ab64d31b3ebb36fbe [diff]
Enable abusive notification revocation on TOT

This CL keeps the fieldtrial config entry for ChromeOS, since this is
going to 20% stable before 100% stable (the rest of Desktop
platforms/Android are going to 100% stable)

While enabling this feature by default, some tests had failures:
-`IndexedHostContentSettingsMapTest` disables
`kSafetyHubAbusiveNotificationRevocation` by default since there are
non-deterministic failures on Android. There is a separate bug to handle
this.
-The `AddRevokedPermissions` helper of
`UnusedSitePermissionsBridgeTest` had a bug and per help from
rubindl@, suggested this change
-`SafetyHubMenuNotificationServiceTestDisableAutoAbusiveNotificationRevocation`
and `UnusedSitePermissionsServiceSafetyHubDisabledTest` needed
`kSafetyHubAbusiveNotificationRevocation` to be explicitly disabled.

Bug: 328773301
Change-Id: I658bc9470cf963b28289cf2f17eb77ae8d9ca475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5805184
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Sarah Krakowiak <skrakowi@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1347360}
6 files changed
tree: 4ab43ae89ad108f609b0c13601ae1b363ff3acba
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.