commit | 1c9b719f8cd4350276985422a2c5253558220852 | [log] [tgz] |
---|---|---|
author | Gaurav Kumar <gauravkum@microsoft.com> | Fri Nov 15 07:09:34 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 15 07:09:34 2024 |
tree | f439a08772f76503a6733a97afa20192d7cee9b2 | |
parent | 42c12e2d527442e1e6ab0dcb6300ce9114c97f17 [diff] |
[views-ax] Migrate kName in TabGroupHeader This CL migrates the kName attribute in views to be updated whenever its value should change, rather than querying the value and computing it only when needed. The accessible name of a TabGroupHeader depends on the following properties: 1. The title of the TabGroup 2. The collapsed state of the TabGroup 3. The content string of the TabGroup, which is influenced by the title of the first tab and the number of tabs in the group. Since the accessible name of the TabGroupHeader depends on the title of the first tab in the group, we track Tab::SetData() whenever it attempts to update the tab’s title. If an update occurs, TabGroupHeader::UpdateAccessibleName() is called. Additionally, whenever a tab is added to or removed from a TabGroup, the accessible name of the TabGroupHeader must be recalculated. To achieve this, we need to add a callback in the TabGroup class and execute it whenever a tab is added or removed. The tab’s title update request is initially handled in WebContents, and then a subsequent UI update is scheduled for the browser to handle. The title update is performed through a delayed task to avoid flickering. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417 Change-Id: I1b9440d4289df7dec3781738d571db0e7deff220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922293 Reviewed-by: Jacques Newman <janewman@microsoft.com> Commit-Queue: Gaurav Kumar <gauravkum@microsoft.com> Reviewed-by: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1383449}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.