Google Git
Sign in
chromium / chromium / src / 1cd94fc12b98f2f7788d509800dc856f45223003
commit1cd94fc12b98f2f7788d509800dc856f45223003[log] [tgz]
authorJonathan Lee <jonathanjlee@google.com>Thu Feb 15 00:51:40 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 15 00:51:40 2024
treed323009131fa5510cf1b82f1d33a5a036da4d92a
parent8e6fd73766f3793c60b881154985b51f0ffe1770 [diff]
[wptrunner] Allow OK for `[ Failure ]` TestExpectations lines

This is a forward-fix for an edge case in https://crrev.com/c/5112639.
When a test has both a `[ Failure ]` TestExpectation and a baseline
harness error, the former should override the latter and expect OK to
avoid triggering retries and shard failure [0].

Reset some wdspec expectations that run expectedly OK.

[0]: https://luci-milo.appspot.com/ui/inv/task-chromium-swarm.appspot.com-67c1e5f865702511/test-results?sortby=&groupby=&q=external%2Fwpt%2Fwebdriver%2Ftests%2Fbidi%2Fbrowsing_context%2Flocate_nodes%2Fmax_node_count.py+

Bug: 40943761
Change-Id: I836701340191e89524e03f3fcc5d02a3babec7b5
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5298315
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1260820}
7 files changed
tree: d323009131fa5510cf1b82f1d33a5a036da4d92a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.