commit 1cd9e38c5bc7aac2341e319f62080f4072626e4e
author Harry Cutts <hcutts@chromium.org> Tue Apr 12 19:36:49 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Apr 12 19:36:49 2022
tree 52d1b02d1fa8cda95971d3698ad7e898db1fe754
parent 8e83658e601ead770f4f4876d752be63161fe1c9

Diagnostics: support Mic Mute and Keyboard Backlight Toggle top-row keys

This should serve as an example CL for how to add support for new top
row keys to the tester.

The HID usage codes in input_data_provider_keyboard.cc were found in the
action_key array in CrOS EC's usb_hid_keyboard.c [0], while scan codes
can be found from running evtest on a DUT, choosing the keyboard,
pressing the key, and checking the value of MSC_SCAN.

I imported the icons into Inkscape from Illustrator files, then removed
extra markup using the XML Editor, and scaled them to fit in 20px. (For
consistency with the other top-row icons that don't fill their 20px
squares, this meant setting the page size to 20x20px, scaling the icon
to 16px, and centering it on the page.) The Apply Transforms plugin [1]
was then used to apply SVG transforms to the path pixel values
themselves, resulting in the <path> elements that could then be added to
keyboard_icons.html. (Visual designers may have a better workflow for
exporting clean SVGs.)

Screenshot (made with fake data putting both icons on the same top row):
http://shortn/_1tGuUfgQAb

[0]: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/ec/chip/stm32/usb_hid_keyboard.c?q=%22struct%20action_key_config%20action_key%22
[1]: https://github.com/Klowner/inkscape-applytransforms

Change-Id: Iadfbff172014d2471e6a2ec1854784495e766167
Bug: 1207678
Test: open the tester on a device with the keys on its top row, check
Test: the icon appears correctly and is described properly by ChromeVox.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564071
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Cr-Commit-Position: refs/heads/main@{#991674}