Introduce History.DomainCount*_V3 metrics The existing "_V2" metrics include foreign/synced visits, which was not intentional. This CL introduces a new set of "_V3" metrics that properly filter out foreign visits. Note that there are two slightly different kinds of foreign visits: - "Legacy"-style visits, coming from TYPED_URLS. These are identified by SOURCE_SYNCED. - "New"-style visits, coming from HISTORY. These are identified by a non-empty originator_visit_id, and also by SOURCE_SYNCED. This CL filters out visits by both conditions, even though only checking for SOURCE_SYNCED would technically be sufficient. The reasons are: a) `visit_source` is barely used otherwise, and might get removed at some point in the future. b) Once `kSyncEnableHistoryDataType` is fully rolled out, the check for `visit_source` will become unnecessary (and checking the `originator_cache_guid` is simpler; no need to access the separate visit_source table). The existing "_V2" metrics are *not* deprecated yet - it's useful to keep them for a while, for ease of analysis and comparing with the new ones. Bug: 1422210 Change-Id: I12cabf24049f63b05c80ec8745dd8f4442bde271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4315807 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#1115601}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.