Google Git
Sign in
chromium / chromium / src / 1d0578e06f34cf9eaf1b29b10b43c354a734c05f
commit1d0578e06f34cf9eaf1b29b10b43c354a734c05f[log] [tgz]
authorPhilip Rogers <pdr@chromium.org>Sat May 18 00:13:04 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat May 18 00:13:04 2024
tree47c0a0d2371cbbaa28d1ea117c744b5ea218ea8e
parentebcbf7ace4fbe1f8c73db677c85ff131069c6100 [diff]
Make sec-ch-width tests robust to fractional values

sec-ch-width.https.html is currently failing when the window width is
not an even multiple of 10 (see: crbug.com/341258938). The spec [1]
states that sec-ch-width must be an integer, and we currently ceil
this (see: `BaseFetchContext::AddClientHintsIfNecessary`). This patch
updates the tests to expect correct integer values.

Bug: 335630145
Change-Id: I2b2704232963a03f6232af4fee5b72ddcf60c8c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546690
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1302921}
4 files changed
tree: 47c0a0d2371cbbaa28d1ea117c744b5ea218ea8e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.