Google Git
Sign in
chromium / chromium / src / 1d0b0609ceddfff71db44e2d52aaf4b5567d9503
commit1d0b0609ceddfff71db44e2d52aaf4b5567d9503[log] [tgz]
authorNathan Hebert <nhebert@chromium.org>Thu Mar 31 20:25:30 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 31 20:25:30 2022
tree64b0593a29375333c5d564ebe82b612c214a0f92
parentb86d11dbcbc051b4d441a506afd91ea0fe8665e3 [diff]
platform_video_frame_utils: Set GMB ID

This ensures that a unique ID is set for new GMB handles created with
CreateGpuMemoryBufferHandle(const VideoFrame*) when the source frame's
storage type is STORAGE_DMABUFS. Every code path that produces a
GpuMemoryBufferHandle should assign a unique ID.

This was found when running tests with VaapiImageProcessorBackend. The
VaapiImageProcessorBackend depends on unique GpuMemoryBufferHandle
|id|'s for its va_surface caching mechanism. Buffer handles produced by
the image processor test code using CreateGpuMemoryBufferHandle did not
have |id| assigned, so there were collisions.

Bug: b:227177979
Test: image_processor_test on hatch
Change-Id: I3f00f2d29e71a49c1454116dada1585849669561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557982
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Nathan Hebert <nhebert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987608}
1 file changed
tree: 64b0593a29375333c5d564ebe82b612c214a0f92
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.