commit 1d93188ba0812000a614069eca57560e2075ea0d
author Christoph Schwering <schwering@google.com> Fri May 03 08:49:32 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 03 08:49:32 2024
tree fcd9063e28709054914107afbedbeb26d6b1511e
parent e6b80838324e0c80c187c6639d96d554871beb6f

[Autofill] Clean up sectioning experiments

This CL cleans up the sectioning experiments
- kAutofillUseNewSectioningMethod
- kAutofillUseParameterizedSectioning.
The former is disabled, the latter is enabled.

As a result, this CL removes
- the original sectioning algorithm FormStructure::IdentifySections()
- its intended successor FormStructure::IdentifySectionsWithNewMethod()
- the Finch parameters from AssignSections().

So now only the simplest version of all implemented sectioning
algorithms is left.

This leads to changes in the sectioning test cases
components/test/data/autofill/heuristics. There are two types of
changes:

1. Most changes affect fields that aren't fillable. In particular,
this includes unfocusable fields. The parameterized sectioning
algorithm ignores such fields.

2. The remaining three test cases are
- 021_checkout_cduniverse.com.out
- 030_checkout_lowes.com.out
- 083_crbug_87517.out
where the new sectioning algorithm performs better.

The parameterized sectioning reveals a difference between form
extraction on iOS and non-iOS: on iOS, readonly or tabIndex="-1"
imply `!FormFieldData::is_focusable()`. The preceding CL
crrev.com/c/5514142 therefore removed all relevant readonly and
tabIndex="-1" attributes from the test input files until form
extraction is consistent across iOS and non-iOS.

Bug: 40159136
Change-Id: I24f7fff32f7a56f01179852c73e59419b7667e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5079434
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1295988}