commit 1de32b7a4187d698beb36da044560838056c9e3e
author David Benjamin <davidben@chromium.org> Thu Nov 14 19:20:05 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 14 19:20:05 2024
tree e8007ff9876c27c624ef6a44e7779caed872e5c5
parent 3f992d444db38c1e2a27c1f3244e38eb446ea6f1

Remove quiche_mutex_impl.h override

This abstraction predates Abseil being consistently available
everywhere QUICHE is used. Nowadays, QUICHE generally depends on
Abseil, but this override still exists.

As QUICHE is a standalone library, dependencies on //base are
tricky at best. Using absl is more straightforward. Per the
discussion below, the absl/synchronization ban is just about 1p
conventions, and not a technical incompatibility:
https://groups.google.com/a/chromium.org/g/cxx/c/oCqPxL7GBtQ/m/YHi08xYOAAAJ

Remove the override so that QUICHE can avoid this now unnecessary
internal abstraction. This also means QUICHE in Chromium more
consistently matches QUICHE as it is developed upstream. (E.g.
Chromium's override silently turned every read lock into a write
lock, so we've been risking deadlocks if QUICHE ever relied on
read locks working.)

Moreover, looking at binary size difference and xrefs for
QuicheMutex/QuicheNotification, it seems QuicheMutex never ends up
in the Chromium binary anyway, just unit tests. So Chromium
especially has no reason to care about this.

If this change sticks, we can follow-up with removing the indirection
from QUICHE.

Change-Id: I05cb018d8ee4c288486238b3767c3a8a3c363fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020098
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1383142}