| commit | 1e1ffe1fda87748d64817f904d696f00a32e2352 | [log] [tgz] |
|---|---|---|
| author | Johannes Henkel <johannes@chromium.org> | Thu Feb 20 02:20:25 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 20 02:20:25 2025 |
| tree | 3484471643b7708cd2b80afc4a5e13ceee54200a | |
| parent | eb5d220272d894b438d937d9387dbbae89a03611 [diff] |
These tests pass locally, and that seems consistent. I ran these on Linux, using this command: third_party/blink/tools/run_wpt_tests.py --target Default -p chrome \ external/wpt/largest-contentful-paint/first-letter-background.html \ external/wpt/largest-contentful-paint/observe-css-generated-text.html \ external/wpt/largest-contentful-paint/text-with-display-style.html \ virtual/scalefactor200/external/wpt/largest-contentful-paint/first-letter-background.html \ virtual/scalefactor200/external/wpt/largest-contentful-paint/observe-css-generated-text.html \ virtual/scalefactor200/external/wpt/largest-contentful-paint/text-with-display-style.html I think after the original cl was submitted which prompted disabling these tests, there was follow-up work, and my guess is that the tests no longer have the original problem. Specifically, I think that https://chromium-review.googlesource.com/c/chromium/src/+/5975665 was submitted after the tests got disabled, and they may have been fine since then, or fine after some of the other changes to third_party/blink/renderer/core/timing/performance.cc. I'm certainly new to this - it could be that there's something else that should be done to the tests, specs, etc. Please let me know what you think. Thanks! Bug: 376491758 Change-Id: I76fbbbd2c98c62d82e6854d8ca4e25d1155a9dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282181 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1422308}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.