Google Git
Sign in
chromium / chromium / src / b6be8d56c26c8c4e495ef25c9df367c559be3c42
commitb6be8d56c26c8c4e495ef25c9df367c559be3c42[log] [tgz]
authorYuwei Huang <yuweih@chromium.org>Fri Dec 03 01:14:44 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 03 01:14:44 2021
tree8cefb1502751331e01ed80e47964fa4b590fdad2
parent112279c27a50ed1ee7b5f84f5333e0f7da5c2152 [diff]
[crd host][windows] Introduce remoting_wix_path build arg

We only build the Chromoting host MSI if the build output is Chrome
branded. This is inconvenient for me as I'm currently testing on my
personal machine that doesn't allow building for Chrome branded, and I
always have to manually comment out the is_chrome_branded check before
building the MSI.

IIUC the main reason we don't enable MSI building on non-Chrome-branded
builds is that the wix dependency is only pulled in by src-internal, so
this CL just introduces a new build argument for me to specify the wix
path, so that I can build the MSI without tweaking the BUILD.gn file on
my personal machine.

This change should have no effect on existing official and non-official
try bots.

Change-Id: I9edd8a04f986b54779399d30a1867d0979f26c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313839
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#947795}
2 files changed
tree: 8cefb1502751331e01ed80e47964fa4b590fdad2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.