Google Git
Sign in
chromium / chromium / src / 1e720fcfaec7eef1fbe4ba714493ad0b51e240d6
commit1e720fcfaec7eef1fbe4ba714493ad0b51e240d6[log] [tgz]
authorColin Blundell <blundell@chromium.org>Wed Jul 03 09:42:05 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 03 09:42:05 2024
tree91437d5a73d58f8a63075c016a0a1566c3292c96
parente2dfd5d939a7f27126b84fd93167539519b74813 [diff]
[//gpu] Don't call Graphite Viz Recorder on the GPU thread

Graphite's Recorder::dumpMemoryStatistics() is supposed to be called
only on the instance's "allowed to invoke ASSERT_SINGLE_OWNER methods"
thread, which is the Viz thread. We currently call it on the GPU main
thread. We haven't detected this issue simply because this method
doesn't happen to be called in test contexts where it would blow up
(see discussion at [1]).

This CL removes the call with a TODO for implementing it properly, which
I will follow up on by executing.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5661538/comment/ae6640b2_a1951cdd/

Bug: 330806170
Change-Id: I5fc0f4e5a6d91421450146c06e3c67f89979f1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672268
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1322673}
1 file changed
tree: 91437d5a73d58f8a63075c016a0a1566c3292c96
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.