commit | 1ed0263eb5578a5a68ed55381dbad7aecfd5a2f3 | [log] [tgz] |
---|---|---|
author | Javier Contreras Tenorio <javiercon@microsoft.com> | Tue Jan 23 00:38:44 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 23 00:38:44 2024 |
tree | 6e0a7bfe7a92cf9b26294b9a92876c4e893f02e4 | |
parent | b42668e3a17b32dc72b74577ecbff218478dd4cb [diff] |
[a11y] SetSelection bug in <textarea> A bug was found where a selection was sent from the browser process with the following html: <textarea id="txt" cols="10" rows="5">hello world text go blue </textarea> The selection was sent from the browser process to be on the inlineTextBox for "text go blue" with offsets 0,4. It was then expected for the selection to be "text". However, the selection would be set on "hell". This was because we had some logic in AXSelection::Select that assumed that the start and end offsets were relative to the atomic text field root, and so the selection was being placed on offsets 0,4 but on the text field root. I've added a check so that we only fall down this logic if the selection's base and extent containers are the text field root. Change-Id: I76bdd8cec020cb6a55a204cc94caed2d56ed987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5207784 Commit-Queue: Javier Contreras <javiercon@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1250562}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.