Google Git
Sign in
chromium / chromium / src / 1efe47ebcfb0ad2e8f4fa5a9fa179e97b10bfeed
commit1efe47ebcfb0ad2e8f4fa5a9fa179e97b10bfeed[log] [tgz]
authorBrian Salomon <bsalomon@google.com>Wed Apr 20 17:43:28 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 20 17:43:28 2022
treec7d8e0aaae56a7d4b9cbda606ad15030773b4791
parentce6efb2a2785d4e0c38b5680483c0dcb43b7ab2b [diff]
DrawImageRectOp calls drawImage when src is entire image and mipmapped.

Skia no longer allows mipmapping with kStrict_SrcRectConstraint and
will downgrade to bilinear filtering.

The reason is that the strict constraint is not really enforceable
beyond the base MIP level. This was handled inconsistently between the
CPU and GPU backends. GPU didn't really enforce the strict subsetting
and CPU creates a new set of MIP levels for each subset rect during
SkCanvas::drawImage (while Chrome goes out of its away to ensure MIP
levels for the entire image are prepared ahead of time only to be
ignored). This will allow Skia to remove dynamic generation of MIP
levels for SkImage subsets from the CPU backend.

Bug: skia:13078


Change-Id: Idccd771d511c47a4dbb596bdfe02dadbc440402c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582892
Reviewed-by: Brian Osman <brianosman@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/main@{#994236}
16 files changed
tree: c7d8e0aaae56a7d4b9cbda606ad15030773b4791
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.