commit 1f18f36eb07e242f484601742ebd7b95c35df219
author Florian Leimgruber <fleimgruber@google.com> Wed Jul 05 12:48:34 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 05 12:48:34 2023
tree 06744e8b90362edacb6c8ae34cf9c000bddaff04
parent 135405aaf2f86c38515aa72f876dd292ff3c0b39

Simplify IsMinimumAddress().

Currently, IsMinimumAddress() is two unnecessary parameters:
- app_locale: It's only used to construct an AutofillCountry object in
  GetAutofillProfileRequirementResult(). However, the optional
  app_locale parameter is only needed to translate the country name.
  If AutofillCountry::name() is not used, like in the case of checking
  requirements, it can be omitted.
- predicted_country_code: All callsites use the profile's country.*
This CL removes them both.

* There's some historical context why it was added in the first place,
  and why it is no longer necessary. In the past, complementing the
  country happened before the multi-step import logic. So during multi-
  step imports (which checks address requirements too), it was necessary
  to recompute the complemented country whenever something was merged.
  [1] changed this behavior and swapped the order. Since then, by the
  any time requirements are checked, the country is already
  complemented.

[1] https://docs.google.com/document/d/1bwgKfCeDdXVMghgDdnJ0Mla-GW8DP2IbMz3mwO_ifk0/edit?resourcekey=0-jr163i3QOo9yrKW3j9yWDA#heading=h.v2wyouz52iot

Bug: 1007974
Change-Id: I8a9c79e7596c7fd9667d2dbc7f0e300e11ab2485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4665585
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Vidhan Jain <vidhanj@google.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1165889}