commit | 1f3dc3cf2d75c8218773bfde101fba722eca81e5 | [log] [tgz] |
---|---|---|
author | Patrick Monette <pmonette@chromium.org> | Tue Jan 28 00:13:51 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 28 00:13:51 2025 |
tree | 389747840233d81185216448ba7674cadcd67616 | |
parent | 4528cdc7951a1d2a48b90b8aed06aa14ef993be4 [diff] |
Modernize WorkerWatcherTest When the test suite was created, some facilities didn't exist, like PerformanceManager::GetProcessNodeForRenderProcessHost() or PerformanceManagerRegistryImpl::GetWorkerWatcherForTesting(). To work around it, ProcessNodeSource and FrameNodeSource were added. This change refactors WorkerWatcherTest to use those facilities. This allows the removal of the ProcessNodeSource class. Additionally, now nodes are held using WeakPtr, which is easier to work with (Can use EXPECT_FALSE(node) to check if the node was really destroyed). The end results is the same tests with less code. Also get rid of RunOnGraph() usage now that the performance manager lives on the UI thread. Bug: 40755583 Change-Id: I579c06cd11e2f1b7ac1cc81470f50bef93aebfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180100 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411968}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.