Google Git
Sign in
chromium / chromium / src / 1f861a78d027c4dcb7b167fef6aeeab63945a528
commit1f861a78d027c4dcb7b167fef6aeeab63945a528[log] [tgz]
authorAndré Kempe <andre.kempe@arm.com>Wed May 01 08:28:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 01 08:28:22 2024
treea7aa3294c32eccdcc4631b8ba5905afebb22239b
parentdd4372a1e5f941c893ac4e907bfa9cff17815210 [diff]
Remove dependency on base::CPU when dealing with MTE or BTI

Various security features depend on detecting support by the cpu.
For speed, those checks use base::CPU::GetInstanceNoAllocation(),
making the feature attackable by modifying the data stored in this
instance.

To mitigate against this kind of attacks, this CL uses the fact
that cpu support is constant through a processes' runtime and
implements a solution using the runtime linker to resolve the
correct functions by using ifuncs. The runtime linker will ensure the
ifuncs are protected from modifications after program start, i.e. when
linking with "-z relo".

Bug: 1521272
Change-Id: I013cecf1a55d03cdd9503ae8c217b842e323a3b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453915
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Andre Kempe <andre.kempe@arm.com>
Cr-Commit-Position: refs/heads/main@{#1294816}
4 files changed
tree: a7aa3294c32eccdcc4631b8ba5905afebb22239b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.