[AsyncSB] Add PostCommitInterstitial browser tests

Previously, several subresource browser tests were disabled because of
kSafeBrowsingSkipSubresources. Some of these tests are in essence
testing the functionality of post commit interstitial and should not
be limited to warnings triggered by subresources.

This CL ports the tests that are relevant to post commit interstitial
under SafeBrowsingBlockingPageAsyncChecksTimingTest. It reveals an
issue that the security indicator is persisted if the Safe Browsing
check is completed between ProcessResponse and FinishNavigation
(see the TODO in SecurityStateGoBackOnPostCommitInterstitial). It
will be fixed in a follow up CL.

The old tests are removed entirely since we plan to clean up the
kSafeBrowsingSkipSubresources flag soon.

This CL also removes the "MAYBE" before
IframeOptInAndReportThreatDetails. We will monitor if this test is still
flaky on Mac.

Bug: 40941453,40934310
Change-Id: I64ea7478bf842ccc726244df5814e6906c120295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282249
Reviewed-by: thefrog <thefrog@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1259959}
1 file changed
tree: e6d5107b69fa90f2598f89d9924b73c904422512
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.