commit | 1fe6b6053b48e6ad0fc451bda135854545c7e3c3 | [log] [tgz] |
---|---|---|
author | Andrey Zaytsev <andzaytsev@google.com> | Fri Feb 26 11:46:44 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 26 11:46:44 2021 |
tree | 6e07545d21d39d15b9f79dc707034913afcdc7d9 | |
parent | 81f3a6482a36ad290fd8b32732897572ac6b3ae9 [diff] |
Revert "Reland "[Controls Refresh Android] Fix thin border for form controls: button, input, progress, etc."" This reverts commit 33bfc24cdea05733d794710c418d218c8e6ee7c9. Reason for revert: crbug.com/1182645 - breaks android-pie-x86-rel Original change's description: > Reland "[Controls Refresh Android] Fix thin border for form controls: button, input, progress, etc." > > This is a reland of c50c499441f7b448d55def02d9db9c47f243900d > > The reason for the revert was that this CL causes failures on some of > the testers bots. They have been addressed in the following: > 1. linux-lacros-tester-rel. Added BUILDFLAG(IS_CHROMEOS_LACROS) check > to ensure the correct expected PNGs are compared. > 2. Mac10.11-Mac10.14 tester bots failure. This was due to additional > text that resulted in too much difference for pixel match. This CL > removed most of the text and bump up the error limits on Mac. > Note: mac_chromium_[10.11 | 10.12]_rel_ng are not due to this CL but > other systemic failures. > In addition, added a check to prevent running dark mode tests on > MacOS <= 10.14. > 3. Win7 Tests: Failure caused by font rendering diff between Win7 and > Win10. Prevent test Button from running in Win7. > > Original change's description: > > [Controls Refresh Android] Fix thin border for form controls: button, input, progress, etc. > > > > Prior to this CL, form controls' border does not respect zoom and > > DSF if they are painted with native theme. This resulted in inconsistent > > border on highDPI display between controls. Form controls that were > > painted in blink, <meter> and multi-select, have a consistent border > > appearance on highDPI with other elements like div {border: 1px solid}. > > While other controls--button, input, progressbar--appear to have a > > thin border on highDPI display. > > > > This CL fixes this issue by passing zoom level from blink to native > > theme and applying the zoom to form controls' border. A decision is made > > by Dev and UX to apply this fix to android only. We felt a general fix > > for all platform introduces side effects that needs further analysis, > > follow-up crbug.com/1179509. > > > > > > > > Bug: 1160104 > > Change-Id: Ied25eca8b39375dbc00de9d09132439787006c3c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2694095 > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Yu Han <yuzhehan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#856492} > > Bug: 1160104 1181215 > Change-Id: I85cc2441b2370a90303f34498ae8502034f6ed37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2714445 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#857878} Bug: 1160104, 1181215, 1182645 Change-Id: If5c00a53f125693a6d59cc4c3f9532e5dcd5fdc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2722171 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#858080}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.