Google Git
Sign in
chromium / chromium / src / 201d4978748685804b4f9f67fe83368f99149112
commit201d4978748685804b4f9f67fe83368f99149112[log] [tgz]
authorXiaocheng Hu <xiaochengh@chromium.org>Wed Jan 23 18:04:01 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 23 18:04:01 2019
treeedfc17fb2c65a65b5932ef53acb0cbe41654cf2e
parentcbd3312d39c94b28933bdc995dc5355652e9e6bc [diff]
Use weak pointer to reference SpellCheckRequest from outside Blink

Blink Oilpan can't automatically remove pending spellcheck requests of a
closed document, as the requests are referenced by SpellCheckProvider,
which is out of Blink. This may become a leak source as revealed by
crbug.com/855383.

This patch prevents leak by changing the reference into a weak pointer.

Bug: 855383
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_rel_ng
Change-Id: Ibdd535ddb51351a3e30776812dcd6ac4234feae3
Reviewed-on: https://chromium-review.googlesource.com/c/1428085
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625260}
3 files changed
tree: edfc17fb2c65a65b5932ef53acb0cbe41654cf2e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .