controlledframe: Ensure that embedded frame's permissions are isolated This CL adds test cases to make sure the ContentSettings of the embedded origin does not affect permission within Controlled Frame. Geolocation fails these test cases because WebView permissionrequest API logic only happens in DecidePermission() which happens when GetPermissionStatus() returns ASK. If GetPermissionStatus() returns GRANTED or DENIED then the WebView permissionrequest API will not get run. This change adds an override for Controlled Frame to return a status without looking up ContentSettingsMap. For Geolocation, the returned status from GetPermissionStatus() is ASK (unless early return due to guards prior to the GuestView logic), which allows it to call into WebView specific logic inside GeolocationPermissionContextExtensions::DecidePermission(). Bug: b/360444412 Change-Id: If19982aef0f4e463e134b4afcd7e77e3d8d34da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798315 Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Chase Phillips <cmp@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Elias Klim <elklm@chromium.org> Commit-Queue: Zelin Liu <zelin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1347592}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.