controlledframe: Ensure that embedded frame's permissions are isolated

This CL adds test cases to make sure the ContentSettings of the embedded
origin does not affect permission within Controlled Frame.

Geolocation fails these test cases because WebView permissionrequest
API logic only happens in DecidePermission() which happens when
GetPermissionStatus() returns ASK. If GetPermissionStatus() returns
GRANTED or DENIED then the WebView permissionrequest API will not get
run.

This change adds an override for Controlled Frame to return a status
without looking up ContentSettingsMap. For Geolocation, the returned
status from GetPermissionStatus() is ASK (unless early return due to
guards prior to the GuestView logic), which allows it to call into
WebView specific logic inside
GeolocationPermissionContextExtensions::DecidePermission().


Bug: b/360444412
Change-Id: If19982aef0f4e463e134b4afcd7e77e3d8d34da9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798315
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Elias Klim <elklm@chromium.org>
Commit-Queue: Zelin Liu <zelin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1347592}
9 files changed
tree: f28c50d419016c2cffb5be0a020b5ec1459ab9a7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.