Google Git
Sign in
chromium / chromium / src / 20b1274003890d6d42807a41daf846948410f355
commit20b1274003890d6d42807a41daf846948410f355[log] [tgz]
authorBen Kelly <wanderview@chromium.org>Thu Dec 06 03:09:11 2018
committerCommit Bot <commit-bot@chromium.org>Thu Dec 06 03:09:11 2018
tree5edf75bf64ce47c946a1fd989be02f8be0482068
parent8b38b5d3ba2bc4e343b756f932ac7b807ffa94da [diff]
CacheStorage: Hold DOM binding objects alive during operations.

We are seeing some DCHECKs trigger that suggest the owning Cache object
is destroyed while an outstanding operation is in progress.  This can
in theory happen in code that operates on the cache, but then discards
its reference while waiting for the promise to settle.

Bug: 912141
Change-Id: Ic82e8b86bb427808df4d7f16326b50998cf6b031
Reviewed-on: https://chromium-review.googlesource.com/c/1364130
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614251}
2 files changed
tree: 5edf75bf64ce47c946a1fd989be02f8be0482068
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .