commit 20d09df23b4d54afd7c9b9f78d2d05611071def8
author Daniel Vogelheim <vogelheim@chromium.org> Fri Feb 16 17:09:13 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 16 17:09:13 2024
tree c352195ac20d4580593597b2666126d26ca613a2
parent 1cf5183d4b71fc342cd35049ac13f8ebdc8f3875

Remove corb_detachable.

This is part of cleanup work to remove CORB code, now that its successor ORB has been enabled. This particular CL removes rarely used functionality that we won't need going forward.

This CL should be largely functionally neutral, but it affects two tests:

- One subtest in PrefetchBrowserTest: It seems the test inadvertently
  relied on caching behaviour of ORB-blocked requests. By changing
  the content type to the empty string the resource is not affected
  by ORB at all, and the test should work as originally intended.

- WPT preload/prefetch-document: The test assertions for cross-origin
  resources are not ORB compatible, because ORB would block those
  resources. The change here makes us pass the test 100%; makes
  Firefox (which has also implemented ORB) pass an additional subtest,
  and doesn't affect WebKit (which apparently doesn't implement
  prefetch).

  Ref: https://wpt.fyi/results/preload/prefetch-document.html?label=master&label=experimental&aligned&q=preload%2Fprefetch-document.html

Bug: 324418206
Change-Id: I2fbaec1a51a0cfd5d6df731a831b8a3c09bf0693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277068
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261708}