| commit | 20f363402c211c0eeb458c7846380eaba66f6724 | [log] [tgz] |
|---|---|---|
| author | Kaan Alsan <alsan@chromium.org> | Wed Feb 05 23:00:27 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 05 23:00:27 2025 |
| tree | 1b06bbe903c3654ad7c3beedecbb213fee950479 | |
| parent | bc3acb9fe7e18eb9a1862c8b4f345e1f60c5b964 [diff] |
Always attempt to set the PageActionView's icon image Previously we weren't setting the page action's icon image if the image size is the same as the desired icon size. This is error-prone when the default image size is already the same as the desired icon image image, since we would never end up setting the view's image model. This CL removes this early exit, so that we always set the image model. Note, the LabelButton::SetImage implementation already optimizes to prevent redundant updates. Bug: 386376455 Change-Id: I269f3fe428b7c7cad162ce78b75ada44ec02fbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6235906 Commit-Queue: Kaan Alsan <alsan@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/main@{#1416490}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.