Google Git
Sign in
chromium / chromium / src / 218b37482048facfb7ffb4a573e5197e9b408f13
commit218b37482048facfb7ffb4a573e5197e9b408f13[log] [tgz]
authormanukh <manukh@chromium.org>Sat Aug 20 01:37:08 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Aug 20 01:37:08 2022
treefea419744d54fca58e3bd3f368fbb07837d451cf
parent77e11d70ecb1d01547a452ab90c821d5b909bc0c [diff]
[omnibox][memories] Nav intent filtering for cluster suggestions.

Currently, cluster actions are hidden when we detect nav intent.
Specifically, when both a) the top scoring suggestion is a navigation
(as opposed to search) and b) it's scored at least 1300.

This CL adds the same restriction to cluster suggestions.

This reuses the existing param 'omnibox_action_on_navigation_intents' &
'omnibox_action_on_navigation_intent_score_threshold' params shared by
the action filtering.

Unlike the action filtering which looks at all result suggestions after
deduping, culling, etc; cluster filtering looks at only search and
history URL providers' suggestions before dedpuing, culling, etc. So
they may differ, but since we're mostly concerned with high scoring
suggestions, and history URL is the dominant nav provider, this should
be sufficient.

Bug: 1327076
Change-Id: I7a4c324da3b1459dd2fb7490c5170cb3b4c4699b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842856
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1037343}
7 files changed
tree: fea419744d54fca58e3bd3f368fbb07837d451cf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.