Add thread checker to ServiceWorkerData This CL adds thread checker to extensions::ServiceWorkerData so that we ensure this is running on the same thread. ServiceWorkerData instance is managed by `service_worker_data`, which is specified with `thread_local` in WorkerThreadDispatcher. In crbug.com/389971360, we see there are some crashes when `ServiceWorkerData::GetServiceWorkerHost()` is called. This happens by hitting CHECK for `bindings_system_`, which is unlikely to be null because it's passed in the constructor as a unique pointer and no explicit deletion in the class. This also adds CHECK if `WorkerThreadDispatcher::GetServiceWorkerData()` is not null in `DidStartServiceWorkerContextOnWorkerThread()`. We don't set the thread checker for the caller, WorkerThreadDispatcher because it can be run on multiple service worker threads. Bug: 389971360 Change-Id: Ibfcbd4e71a55d7305a9f388347f59516d9569261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179044 Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Keita Suzuki <suzukikeita@chromium.org> Commit-Queue: Shunya Shishido <sisidovski@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#1410082}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.