Google Git
Sign in
chromium / chromium / src / 21d39304c44aeabb6b784c1f0b4e8d553ad05026
commit21d39304c44aeabb6b784c1f0b4e8d553ad05026[log] [tgz]
authorBo Majewski <majewski@chromium.org>Wed Jun 28 06:09:40 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 28 06:09:40 2023
tree93b9a7bcb49051f5ee571aeab85fa0323ee59c28
parent5d97a5520066f525b590e117f786363028a4e990 [diff]
[Files]: Fix UMAs collection for pure JS approach.

When using makeReadEntriesRecursivelyPromise_ we may call the resolve in
the "error" handling branch. This is due to the fact that
util.readEntriesRecursively does not distinguish between true error
condition and the case when we have enough entries. We detect that
condition by checking if there are some entries collected and the
scanning has not been cancelled. However, that branch was missing a call
to recordInterval. Which means that if we use JS code to search for
files and we find more than maxResults, we were not recording any UMAs.
This CL fixes that situation.

Bug: b:288183953
Change-Id: I51a3d18afe28ec2dceab4863cc1096863c0bd473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4648733
Commit-Queue: Bo Majewski <majewski@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1163399}
1 file changed
tree: 93b9a7bcb49051f5ee571aeab85fa0323ee59c28
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.