Google Git
Sign in
chromium / chromium / src / 21f3b1ad6b911c54b53c8c800b17349e0a907485
commit21f3b1ad6b911c54b53c8c800b17349e0a907485[log] [tgz]
authorJonathan Ross <jonross@chromium.org>Fri Apr 23 15:30:27 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 23 15:30:27 2021
tree99c43e47677da8b6266c0cf03b578999f3bb3fff
parent2ea40ff82857d7d9e9f4848512ad13a33aa6018a [diff]
Cannot Trace Invalid viz::LocalSurfaceIds

We do not want to generated Tracing Hash values for invalid viz::LocalSurfaceIds. As they will never be embedded anyways.

Unfortunately due to unit testing, and long standing disconnect in Renderer and Browser startup (https://crbug.com/419087), there are several paths that can lead to us attempting to trace these.

This change prevents the attempting to trace in these conditions, so that we don't crash tracing. Addressing the various root causes would be a significant overhaul and something to consider for the future.

Bug: 1185286
Change-Id: I7a19dbd64d14031793ed98d68ab49eb5b744344a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826792
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875679}
2 files changed
tree: 99c43e47677da8b6266c0cf03b578999f3bb3fff
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.