commit | 221f0366458c757f2fda034e78d25a80bcf2bc6c | [log] [tgz] |
---|---|---|
author | Kentaro Hara <haraken@chromium.org> | Mon Aug 22 16:36:02 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 22 16:36:02 2022 |
tree | 2c5535d22c38aaeeaf614def80f799a27210b01d | |
parent | 2975eeacab8fd698e4f38051d7ed06886d967533 [diff] |
Remove inactive owners from /chrome/browser/ui/webui/access_code_cast Per discussion on the chromium-dev@ thread [1], we remove owners who made 0 commits / reviews to the Chromium repository in the past 12 months (2021/7/26 - 2022/7/26). For each owner removal, we upload a CL to remove the owner. The CL adds the owner being removed and two other owners as reviewers. The CL will be committed once it gets an LGTM from one of the reviewers. Instructions: - The guiding principle is: only owners who are meeting the owner's expectations [2] should be written in OWNERS files. This is important to ensure that developers can find active owners by looking at the OWNERS files. - Please LGTM or not-LGTM the CL based on the removal guideline [3]. i.e., if the owner being removed was inactive only for a certain period of time while they were on a long leave and has been meeting the owner's expectations in other times, please not-LGTM the CL. Otherwise, please LGTM the CL. - If the CL was LGTMed and landed by mistake (e.g., the reviewer was not aware of the owner's leave status), we can just revert the CL. - If you have any questions / comments, please send an explicit email to haraken@chromium.org. (haraken@ is not watching all the comments of all the removal CLs :-) If there is any disagreement between owners, it will be escalated to Chrome Eng Review and resolved per [3]. [1] https://groups.google.com/a/chromium.org/g/chromium-dev/c/aGC8BTTFK64 [2] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#expectations-of-owners [3] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#removal-of-owners This CL was uploaded by git cl split. R=bmalcolm@chromium.org, bzielinski@google.com, jacqueli@google.com Bug: 1355150 Change-Id: I1e6ec0a9abbbb43b596b3fcd3ceb313748e49a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3844666 Auto-Submit: Kentaro Hara <haraken@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1037794}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.