commit | 225bd13db61e4a308e8a34874ed894311107b64c | [log] [tgz] |
---|---|---|
author | Nina Satragno <nsatragno@chromium.org> | Wed Feb 09 20:18:20 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 09 20:18:20 2022 |
tree | 5c2ed565977df7c3274198fbb0c64c1e93154e50 | |
parent | 4fc87f675eb29acab87ccb12e49babe1b9fab8f7 [diff] |
Reland "[CT] Hashdance: Pick SCT and plumb its leaf hash" This is a reland of 837d8719146ed8579c08857fc6c014b12645355a Fell for the classic chromium blunder of putting code that always needs to run inside a DCHECK. Original change's description: > [CT] Hashdance: Pick SCT and plumb its leaf hash > > If SCT reporting is in hashdance mode, have SCTAuditingHandler pick a > single SCT and calculate its leaf hash before plumbing the SCT report > down to the SCTAuditingReporter. The leaf hash is then stored with > SCTAuditingReporter and serialized / deserialized accordingly. > > To avoid having SCTAuditingCache know about the SCT auditing mode, the > dependency between SCTAuditingCache and SCTAuditingHandler is inverted > (reillyg@ suggested this change in an earlier CL as well). Most of the > changed LOCs in this CL are therefore related to moving the relevant > tests. > > Design doc: > https://docs.google.com/document/d/16G-Q7iN3kB46GSW5b-sfH5MO3nKSYyEb77YsM7TMZGE > > Bug: 1249925 > Change-Id: Iae47c82638822b5705ca8f8ae36e2f27c151be33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3445621 > Reviewed-by: Chris Thompson <cthomp@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#968625} Bug: 1249925 Change-Id: Iec851cbcb56e5dd547bec4583802df6f7bb2d23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3450576 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#969077}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.