Google Git
Sign in
chromium / chromium / src / 228be95c585e9da1299c2c1144fd99baed1fc8ec
commit228be95c585e9da1299c2c1144fd99baed1fc8ec[log] [tgz]
authorAndrew Williams <awillia@chromium.org>Thu Jan 26 15:13:01 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 26 15:13:01 2023
treea0e84fae7962a3a7cb01df7b6f85d9c38c22aaa9
parentf003a1d132348d1f78fec7dfbb63637e64cd15cc [diff]
Rename UnguessableToken Deserialize2 to Deserialize

This CL is part of a series to update
base::UnguessableToken::Deserialize to return an
absl::optional instead of an "empty" token in the
case where deserialization fails.

Previous CLs:

0. Add UnguessableToken::Deserialize method that returns optional
    - https://chromium-review.googlesource.com/c/chromium/src/+/4133328

1. Replace UnguessableToken::Deserialize with CreateForTesting in tests
    - https://chromium-review.googlesource.com/c/chromium/src/+/4162456

2. Use new UnguessableToken::Deserialize method in most places
    - https://chromium-review.googlesource.com/c/chromium/src/+/4135540

3. Return absl::optional from FromJavaUnguessableToken
    - https://chromium-review.googlesource.com/c/chromium/src/+/4135783

4. Return absl::optional from UnmarshalUnguessableToken
    - https://chromium-review.googlesource.com/c/chromium/src/+/4133481

5. Use new UnguessableToken::Deserialize in CreateForTesting
    - https://chromium-review.googlesource.com/c/chromium/src/+/4143338

6. Remove the old UnguessableToken::Deserialize
    - https://chromium-review.googlesource.com/c/chromium/src/+/4143958

Bug: 1402549
Change-Id: I2fda3d36e48e6af9b1e90d5a4fa2b1003546057a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193090
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Andrew Williams <awillia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1097381}
36 files changed
tree: a0e84fae7962a3a7cb01df7b6f85d9c38c22aaa9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.