commit 22c6210b04054b2f6bf0596fd30de2e216395460
author cassycc <cassycc@google.com> Mon Jul 08 03:39:14 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 08 03:39:14 2024
tree b02cc3611f62339bd8ccaf956229b6cece9e3d73
parent ee3c50e478b9249d24986107783f300d6e08c856

[office] Refactor setting the reauth required empty folder svg

When the scan for the ODFS file list fails because reauthentication is
required, a special SVG is shown in the empty folder and ODFS is set to
non-interactive. The previous logic was to first set ODFS as
non-interactive and then when updating the UI, use the special SVG if
the volume is non-interactive.

This won't work once other special SVGs are introduced for other errors
that also set ODFS to non-interactive (b/330786891) as ODFS being
non-interactive won't imply which SVG to use.

Instead refactor this so that upon the scan failure, the SVG is set
based on the error. This can be directly passed to updateUi_(). Also
introduce an OdfsMetadata interface to collect the ODFS metadata that is
used to determine if reauth is required and will be used to determine
other error states.

This CL doesn't add anything new. A follow up CL:5669224 will add new
SVGs.

Test: browser_tests --gtest_filter=FileManagerJsTest.EmptyFolderControllerTest
Bug: b/330786891
Change-Id: Ic17b53d6fcc99211abb37b2bfd8f6747c54262f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5677804
Reviewed-by: Alexander Bolodurin <alexbn@chromium.org>
Commit-Queue: Cassy Chun-Crogan <cassycc@google.com>
Cr-Commit-Position: refs/heads/main@{#1324020}