commit 22f28c0ab97f90bc4e08bcb2d72370a50b8f40b5
author Cam Bickel <cambickel@google.com> Tue Dec 13 20:03:02 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Dec 13 20:03:02 2022
tree 2057fb64d309fe91f950a93b5478a06480ce324a
parent d03948976c78052dae446f1c270001c503a679f0

shortcuts: Add replacement key_display for shortcuts missing key_display

This CL fixes the blank keys in the app (see screenshots below for
examples) caused by missing key_display values.

Screenshot 1 Before: https://screenshot.googleplex.com/A4jL5m7WMhZ4gDA
Screenshot 1 After: https://screenshot.googleplex.com/5xXUtfaUAMP594D
Screenshot 2 Before: https://screenshot.googleplex.com/4mxtzyMEScj86xM
Screenshot 2 After: https://screenshot.googleplex.com/7tzYt5JhvRF2ZVW

These empty key_display values occur when the function
`KeycodeToKeyString` returns an empty string for a given key_code. To
work around this without affecting other consumers of that function,
I've added a map with key_display values for the missing keys.

These key_display values will ultimately be turned into icons by the
frontend. For example, MicrophoneMuteToggle is rendered as an icon in
screenshot 2. The other keys will be replaced with icons in future CLs
once we get the SVGs from Design.

Below is a file-by-file explanation.

In accelerator_configuration_provider.h, I move
GetKeyDisplay so that it's public and therefore visible to
the test. I also move CreateAcceleratorInfo from the anonymous
namespace to a private method on the provider.

In accelerator_configuration_provider.cc, I add the lookup map and
GetKeyDisplay function. Note that GetKeyDisplayMap returns a static map
to work around the fact that strings cannot be part of constexprs.
I also move CreateAcceleratorInfo from the anonymous namespace to the
provider.

In acceleration_configuration_provider_unittest.cc, I add tests for
GetKeyDisplay.

Bug: b/216049298
Test: browser_tests --gtest_filter=ShortcutCustomizationApp*
Change-Id: Id4940f00a175cab9c60d3bc28688e4b426b9357b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4083841
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Camden Bickel <cambickel@google.com>
Cr-Commit-Position: refs/heads/main@{#1082672}