Google Git
Sign in
chromium / chromium / src / 22f65698678834d8c1efd258d12f8b712b6917a6
commit22f65698678834d8c1efd258d12f8b712b6917a6[log] [tgz]
authorRaymes Khoury <raymes@chromium.org>Tue Aug 31 01:45:01 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 31 01:45:01 2021
tree91da0edff806fa1755e3a037a651d5741f555ff2
parentbb5c126bd6d5b62f002d8631d7249d143bb2cf08 [diff]
Revert "Convert thread checks to CHECKs to rule out races in crbug.com/1237267"

This reverts commit 201c1d01e5d8c3cd13a67749b9a8551ca0d5341f.

Reason for revert: There is no evidence that these CHECKs are being triggered

Original change's description:
> Convert thread checks to CHECKs to rule out races in crbug.com/1237267
>
> This converts thread checks in AppRegistryCache to be CHECKs rather than
> DCHECKs to rule out concurrent read/writes.
>
> These should be removed after crbug.com/1237267 is resolved.
>
> BUG=1237267
>
> Change-Id: Ieaa0820357b529ec7bda65a5c6d3eb67e6112a44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3097257
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Commit-Queue: Raymes Khoury <raymes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#912801}

Bug: 1237267
Change-Id: If29a26756fb01d9b647e49c9f476239a65515dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3131944
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916641}
2 files changed
tree: 91da0edff806fa1755e3a037a651d5741f555ff2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.