commit 230402472e1a5c2929d81d48e5b3843e31dde317
author Peter Kasting <pkasting@chromium.org> Mon Jan 06 22:41:48 2020
committer Commit Bot <commit-bot@chromium.org> Mon Jan 06 22:41:48 2020
tree 6805fdd6b78dc788bc4e105de86fdf2c7b667ac0
parent 10ebffd7e596c9ad47d04e8f4009a7643e0bd227

Improve ThemeService unit test robustness, and clean up.

* Fixes some (but not all) "Could not delete temp dir" warnings by adding a new
  ThemeScoper object.  This is the bulk of this change.
* Fixes some tests that failed on sytems with dark mode on by default.
* Cleans up some tests by removing unnecessary bits (e.g.
  UseDefaultTheme()/RunUntilIdle() calls on test start) and refactoring (e.g.
  adding a |theme_service_| convenience member alongside the existing
  |registry_|).

Bug: none
Change-Id: Ie5c3fcccda294a863c6a598a0513f076788b314d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986284
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728675}