Clean up wtf_annotations.h a bit.

- Use global DYNAMIC_ANNOTATIONS defines instead of having redundant
  WTF_USE defines that are also global and set at exactly the same time.
  Removes a global define in debug and in tsan builds.

- Remove WTF_ANNOTATE_BENIGN_RACE_SIZED, WTF_ANNOTATE_HAPPENS_BEFORE,
  WTF_ANNOTATE_HAPPENS_AFTER which are all not used.

- Add a comment pointing out that the remaining function works by virtue
  of having a magic name that's hardcoded in the tsan runtime.

While here, also stop globally defining _HAS_ITERATOR_DEBUGGING on Windows
when using libc++ (since _HAS_ITERATOR_DEBUGGING is a Microsoft standard
library thing).

No intended behavior change.

Bug: 961767
Change-Id: I1adec49a2404b4e07dd5270ff64072ca7ebae7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619831
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661701}
4 files changed