commit | 23730651436006b8d3af73a95521807a3308b2a2 | [log] [tgz] |
---|---|---|
author | David Roger <droger@chromium.org> | Mon Nov 28 14:25:02 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 28 14:25:02 2022 |
tree | 1341142c604d62fc913eca3cfde752dcaaee58bb | |
parent | 66a22da20722e4e26a59e11bee695895ba15209d [diff] |
Split profile deletion code out of ProfileManager This CL splits some logic related to profile deletion to separate files. This hopefully makes the code more readable, as the ProfileManager was very large and poorly organized. It should be a pure refactoring with no behavior change. This is mostly a code move, although some other minor changes were required, like moving a few functions from the unnamed namespace to the `ProfileManager` API. It also removes `ScheduleProfileForDeletion()` from the public API, as it was only called by tests. The tests were updated to call `MaybeScheduleProfileForDeletion()` instead. In a follow-up change, the KeepAlive management in `DeleteProfileHelper` will be improved to fix a bug where Lacros exits immediately at startup while trying to delete a profile. Bug: 1382815 Change-Id: I49b4ecee7a83dcce3a0d6826982780ba8dbd0be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055710 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1076189}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.