corner-shape: compute path given curvature & offset

To render borders & shadows at constant thickness along the superellipse
(or gradual if interpolating between two border widths), we do the
following:

- Keep the original border-rect as an "origin rect", so that we can
  reference it,
  when outsetting/insetting.
- When rendering the "target rect" (the rect with the inset/outset),
  we extend
  the radius of the origin rect by the offset, keeping the same center.
- For 0.5<curvature<2, the radius needs to be extended beyond the
  inset/outset,
  as the thickness at the meeting point with the origin rect can be up
  to sqrt(2)
  thicker than the actual border width.
- Instead of rendering concave corners, we flip the vertex's center and
  outer points, to simplify computations.

Since corners with offset don't start/end at a point on the target
rect, and can overlap in some extreme situations, path intersection
logic is
used to create the result path. We intersect the target rect (without
any corners), together with two paths, each taking into account the
opposite diagonal corners, since diagonal corners cannot intersect.

Added a few helpers:
- Some helpers for RectVertex in path.cc
- Normalize functions for Vector2d.

Note that this is still insufficient in order to correctly draw concave
borders with a color, since the per-side color clipping needs to be
fixed (in a subsequent CL as this one is big enough).

Bevel and convex borders are rendered correctly now. The tests for
bevel+border can now use the same tests as the other variants use.

Bug: 399449172
Change-Id: Ib799423322c29270c678594eb6f6ed8a4a3a9a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6368660
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434931}
11 files changed
tree: 6580170e428520654337db06e7f3349f0667cff5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.