Google Git
Sign in
chromium / chromium / src / cf97f3f89a5ac7d087004a1dc2d72d375315b040
commitcf97f3f89a5ac7d087004a1dc2d72d375315b040[log] [tgz]
authorRakina Zata Amni <rakina@chromium.org>Wed Sep 02 15:42:19 2020
committerCommit Bot <commit-bot@chromium.org>Wed Sep 02 15:42:19 2020
treeebdf3c4842989e69814f6821f4d0f37ebb4760bc
parent4a7fc4dab2e4582ea74245ef680bb33f5d9cab20 [diff]
Update history info in renderer when page gets restored from bfcache

Currently we only update the history info on renderer on
CommitNavigation calls and some cases where we're deleting navigation
entries. When restoring a page from the back-forward cache, we would not
call CommitNavigation on it (we call SetPageLifecycleState instead),
so the history info might be stale after restoring.

This CL adds history offset & length along with the pre-existing param
navigation_start as PageRestoreParams to send with the
SetPageLifecycleState calls to restore the page, so that the history
offset & length can be updated in that case too.

Bug: 1122508
Change-Id: Ia480fe199c7836c923fd9d786610a991ce7c8a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379393
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803869}
14 files changed
tree: ebdf3c4842989e69814f6821f4d0f37ebb4760bc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.