[chromecast] Reenable v8_use_external_startup_data, disable include_both_v8_snapshots.

We had disabled v8_use_external_startup_data to work around
b/419216998, but
https://chromium-review.googlesource.com/c/chromium/src/+/6602174
made a change that broke builds where v8_use_external_startup_data is
false but include_both_v8_snapshots is true (b/422518569).

Simply restoring v8_use_external_startup_data still regresses to the
original issue, I think because we are only bundling
snapshot_blob_64.bin in the apk, rather than "both" snapshots as the
buildflag describes. Disabling include_both_v8_snapshots on its own also
works, but leaves cast_browser more divergent from other chromium
Android builds than it would be if we used v8_use_external_startup_data.

This combination of buildflags seems best for now, though it may be
worth looking into better protections against this kind of regression:

  * Assert that include_both_v8_snapshots is false if
    v8_use_external_startup_data is false, or make C++ code that checks
    the buildflags check the latter before checking the former
  * Explicitly setting both buildflags in android.gni, so changes to
    defaults in e.g. v8_context_snapshot.gni  don't affect cast_browser
    unintentionally
  * Introduce some kind of browser test that runs on Android
    labs/emulators in chromium infra to verify that the browser can
    start up a web page, which would fail fast if loading the v8
    snapshots fails

Bug: 422518569
Bug: 421165374
Test: build cast_browser_aar, build mediashell arm64 release apk
Test: cast YouTube to Pixel Tablet (uses arm64 abi)
Change-Id: I175d54babb1b7851f2cb64ad28a2b440550affde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6622101
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Sandeep Vijayasekar <sandv@google.com>
Commit-Queue: Sandeep Vijayasekar <sandv@google.com>
Cr-Commit-Position: refs/heads/main@{#1469702}
1 file changed
tree: 21c28417ef5227a360799aef412eccd2f3c9e04d
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. SECURITY_OWNERS
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.