commit 246939ae8a0a992cc5a4e6aa29ad3c0466ac4d03
author Kelvin Jiang <kelvinjiang@chromium.org> Wed May 15 03:44:31 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 15 03:44:31 2024
tree c14b1eda6db9a79ea2358ad3f2f14e57095cd23c
parent f2eb496d85b77ad7cd18ddb64021785bf36e0552

[DNR] Fix use after std::move for modify header action

This issue was caused by the MODIFY_HEADERS block in OnHeadersReceived
which std::move actions, therefore invalidating it, before the
containing for loop tries to access the next element in actions.

In the switch() blocks by action type, only the first action really
needs to be examined, since:
 - for MODIFY_HEADERS actions, in OnBeforeRequest, only a DCHECK is
   performed to ensure that all actions returned are MODIFY_HEADERS.
   In OnHeadersReceived, actions returned from that phase are merged
   with actions from OnBeforeRequest. This also only needs to be
   executed once.
 - for all other action types, the switch blocks DCHECKS that there is
   only one action.

^So the for loop can be changed to an if statement that only checks
the first action returned.

The failing test case from asan, ModifyHeaders_SingleExtension, is also
re-enabled.

Bug: 340136384
Change-Id: I31edd520ec12edd63c44780b83dbe8a48159147e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5536450
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301076}