Google Git
Sign in
chromium / chromium / src / 24c22cc07d117cb29cc0e85effd9ee3abdb68f9d
commit24c22cc07d117cb29cc0e85effd9ee3abdb68f9d[log] [tgz]
authorPatrick Noland <pnoland@google.com>Mon Apr 21 17:30:56 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 21 17:30:56 2025
tree56a387706c1b3ac0d944665cc896e2d5052287f0
parentb00856f07fd2ce44b0bcc5b1a7cb9da49cd2f637 [diff]
[mobar] Hide edge to edge chin completely when keyboard is visible

Currently, the chin's layer visibility is "visible when others visible"
when the soft keyboard is up. This effectively hides it because all the
other layers either move or hide when the keyboard is up:
* Readaloud and tabgroup strip hide
* Toolbar moves to the top and is hidden as far as the stacker is
  concerned

For mini origin bar, the toolbar needs to stay on the botom, so this
logic no longer works. The chin remains at the bottom of the screen,
under the keyboard, but offsets the toolbar by its height, leaving a
visible gap.

To address this, we can fully hide the chin when the keyboard is up.

Bug: 411202039
Change-Id: I67d08b6f2d0343f7794c2ee7cd1234ae562f3189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6472851
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1449496}
2 files changed
tree: 56a387706c1b3ac0d944665cc896e2d5052287f0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.