Reland "Ignore echo cancellation for all sources except mic and desktop capture." This reverts commit 22cfa1732484d5b19b25df576b12a8e6200158a3. Reason for revert: making sure echo cancellation is not applied Original change's description: > Revert "Ignore echo cancellation for all sources except mic and desktop capture." > > This reverts commit 45baca190cc32be227effd2712ecee20d00da67b. > > Reason for revert: Needs a little fix > > Original change's description: > > Ignore echo cancellation for all sources except mic and desktop capture. > > > > Various sources such as GUM_DESKTOP_AUDIO_CAPTURE, GUM_TAB_AUDIO_CAPTURE, etc. may have echo cancellation on by default - but it's not applicable, so we should just ignore it. Platform echo cancellation would only be activated for mic streams, in case there is a platform effect available. > > > > Bug: 443695127 > > Change-Id: I9dd6b46d278b3feda81aef0577dea480e5b41f9e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6930297 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Commit-Queue: Olga Sharonova <olka@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1513208} > > Bug: 443695127 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: Ie4660f365dcc42fe83d35bbdc8e8e43b73527b0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6932503 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1513239} Bug: 443695127 Change-Id: I1b5ed21fbfb07cba7d9e8f156870db3692b49e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6935363 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/main@{#1513707}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.